Bug 41512 - girar-task-make-index-html: do not rely on yastatic.net, embed css instead
Summary: girar-task-make-index-html: do not rely on yastatic.net, embed css instead
Status: NEW
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: girar (show other bugs)
Version: unspecified
Hardware: all Linux
: P5 normal
Assignee: placeholder@altlinux.org
QA Contact: Andrey Cherepanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-06 18:21 MSK by Dmitry V. Levin
Modified: 2021-12-08 18:27 MSK (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry V. Levin 2021-12-06 18:21:36 MSK 
girar-task-make-index-html generates the following:

  <head>
    <meta name="robots" content="index, nofollow"/>
    <link href="https://yastatic.net/bootstrap/3.3.4/css/bootstrap.min.css" rel="stylesheet" />
    <title>Task #$id for $repo by $owner</title>

This is fragile, css should be local, there should be no reliance on yastatic.net.
Comment 1 Arseny Maslennikov 2021-12-08 18:27:25 MSK 
(In reply to Dmitry V. Levin from comment #0)
> girar-task-make-index-html generates the following:
> 
>   <head>
>     <meta name="robots" content="index, nofollow"/>
>     <link href="https://yastatic.net/bootstrap/3.3.4/css/bootstrap.min.css"
> rel="stylesheet" />
>     <title>Task #$id for $repo by $owner</title>
> 
> This is fragile, css should be local, there should be no reliance on
> yastatic.net.

Even more, the first sub-element of the document head is not "<meta charset="utf-8" />".